Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DPE-2778] Shard removal tests #283

Merged
merged 22 commits into from
Nov 2, 2023
Merged

[DPE-2778] Shard removal tests #283

merged 22 commits into from
Nov 2, 2023

Conversation

MiaAltieri
Copy link
Contributor

@MiaAltieri MiaAltieri commented Oct 26, 2023 •
edited
Loading

Issue

No tests for shard removal

Solution

Add tests for various removal scenarios

Extras

  1. These tests highlighted an issue with slow drainage. A large TIMEOUT period has been added to the tests and an issue (MongoDB, slow chunk Migration for collection config.system.sessions with removing Shard - Config server relation #282 ) has been added to the repo
  2. Wait for relation_changed to be given both key and ops password, as these seem to not always be given from the config server on relation-joined. discussed here

@MiaAltieri MiaAltieri force-pushed the shard-removal-test branch 2 times, most recently from b37093c to b8c1fde Compare October 27, 2023 11:54
delgod
delgod previously approved these changes Nov 1, 2023
View reviewed changes
lib/charms/mongodb/v1/shards_interface.py Show resolved Hide resolved
@MiaAltieri MiaAltieri merged commit fc891d5 into 6/edge Nov 2, 2023
17 checks passed
@MiaAltieri MiaAltieri deleted the shard-removal-test branch November 2, 2023 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmitry-ratushnyy dmitry-ratushnyy dmitry-ratushnyy approved these changes

@delgod delgod delgod approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MiaAltieri @delgod @dmitry-ratushnyy